Increase Machine Disk Size has no effect

[milafrerichs]

Issue Description

When I try to increase the disk size of my podman machine it shows it correctly in the interface when the machine is stopped but once the machine starts it does not reflect the new size.
this also happens when doing it via the CLI.
I'm running a Mac Mini M4.

I added my remarks in #20564 a month ago to no effect.

Steps to reproduce the issue

Steps to reproduce the issue

1. Create a machine
2. Increase the disk size of the machine
3. Check the size of the machine

Describe the results you received

The machine shows still the old size

Describe the results you expected

The machine should show and use the new disk size.

podman info output

➜  ~ podman info
Client:
  APIVersion: 5.4.1
  BuildOrigin: pkginstaller
  Built: 1741718260
  BuiltTime: Tue Mar 11 19:37:40 2025
  GitCommit: b79bc8afe796cba51dd906270a7e1056ccdfcf9e
  GoVersion: go1.24.1
  Os: darwin
  OsArch: darwin/arm64
  Version: 5.4.1
host:
  arch: arm64
  buildahVersion: 1.38.1
  cgroupControllers:
  - cpuset
  - cpu
  - io
  - memory
  - pids
  - rdma
  - misc
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.1.12-3.fc41.aarch64
    path: /usr/bin/conmon
    version: 'conmon version 2.1.12, commit: '
  cpuUtilization:
    idlePercent: 99.52
    systemPercent: 0.26
    userPercent: 0.23
  cpus: 5
  databaseBackend: sqlite
  distribution:
    distribution: fedora
    variant: coreos
    version: "41"
  eventLogger: journald
  freeLocks: 2043
  hostname: localhost.localdomain
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 6.12.7-200.fc41.aarch64
  linkmode: dynamic
  logDriver: journald
  memFree: 3802689536
  memTotal: 4767236096
  networkBackend: netavark
  networkBackendInfo:
    backend: netavark
    dns:
      package: aardvark-dns-1.13.1-1.fc41.aarch64
      path: /usr/libexec/podman/aardvark-dns
      version: aardvark-dns 1.13.1
    package: netavark-1.13.1-1.fc41.aarch64
    path: /usr/libexec/podman/netavark
    version: netavark 1.13.1
  ociRuntime:
    name: crun
    package: crun-1.19.1-1.fc41.aarch64
    path: /usr/bin/crun
    version: |-
      crun version 1.19.1
      commit: 3e32a70c93f5aa5fea69b50256cca7fd4aa23c80
      rundir: /run/crun
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +LIBKRUN +WASM:wasmedge +YAJL
os: linux
  pasta:
    executable: /usr/bin/pasta
    package: passt-0^20241211.g09478d5-1.fc41.aarch64
    version: |
      pasta 0^20241211.g09478d5-1.fc41.aarch64-pasta
      Copyright Red Hat
      GNU General Public License, version 2 or later
        <https://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
      This is free software: you are free to change and redistribute it.
      There is NO WARRANTY, to the extent permitted by law.
  remoteSocket:
    exists: true
    path: unix:///run/podman/podman.sock
  rootlessNetworkCmd: pasta
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: false
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: true
  serviceIsRemote: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.3.1-1.fc41.aarch64
    version: |-
      slirp4netns version 1.3.1
      commit: e5e368c4f5db6ae75c2fce786e31eef9da6bf236
      libslirp: 4.8.0
      SLIRP_CONFIG_VERSION_MAX: 5
      libseccomp: 2.5.5
  swapFree: 0
  swapTotal: 0
  uptime: 36h 55m 28.00s (Approximately 1.50 days)
  variant: v8
plugins:
  authorization: null
  log:
  - k8s-file
  - none
  - passthrough
  - journald
  network:
  - bridge
  - macvlan
  - ipvlan
  volume:
  - local
registries:
  search:
  - docker.io
store:
  configFile: /usr/share/containers/storage.conf
  containerStore:
    number: 4
    paused: 0
    running: 3
    stopped: 1
  graphDriverName: overlay
  graphOptions:
    overlay.imagestore: /usr/lib/containers/storage
    overlay.mountopt: nodev,metacopy=on
  graphRoot: /var/lib/containers/storage
  graphRootAllocated: 13000454144
  graphRootUsed: 11576360960
  graphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Supports shifting: "true"
    Supports volatile: "true"
    Using metacopy: "true"
  imageCopyTmpDir: /var/tmp
  imageStore:
    number: 6
  runRoot: /run/containers/storage
  transientStore: false
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 5.3.2
  Built: 1737504000
  BuiltTime: Wed Jan 22 01:00:00 2025
  GitCommit: ""
  GoVersion: go1.23.4
  Os: linux
  OsArch: linux/arm64
  Version: 5.3.2

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

No response

Additional information

➜  podman exec -it conatiner-1 df -h
Filesystem                            Size  Used Avail Use% Mounted on
overlay                                13G  9.4G  2.8G  78% /
tmpfs                                  64M     0   64M   0% /dev
tmpfs                                 910M  724K  909M   1% /etc/hosts
shm                                    63M  4.0K   63M   1% /dev/shm
a2a0ee2c717462feb1de2f5afd59de5fd2d8  229G  181G   48G  80% /app/backend/data
devtmpfs                              4.0M     0  4.0M   0% /proc/keys

➜  podman machine inspect
[
     {
          "ConfigDir": {
               "Path": "/Users/xxx/.config/containers/podman/machine/applehv"
          },
          "ConnectionInfo": {
               "PodmanSocket": {
                    "Path": "/var/folders/fq/58154kz90f9_0b0wsfpn0qg80000gn/T/podman/podman-machine-default-api.sock"
               },
               "PodmanPipe": null
          },
          "Created": "2025-01-29T09:28:10.528768+01:00",
          "LastUp": "2025-03-20T09:30:16.361953+01:00",
          "Name": "podman-machine-default",
          "Resources": {
               "CPUs": 5,
               "DiskSize": 25,
               "Memory": 4768,
               "USBs": []
          },
          "SSHConfig": {
               "IdentityPath": "/Users/xxx/.local/share/containers/podman/machine/machine",
               "Port": 62249,
               "RemoteUsername": "core"
          },
          "State": "running",
          "UserModeNetworking": true,
          "Rootful": true,
          "Rosetta": true
     }
]

[mheon]

Please provide a proper reproducer with exact commands used.

[mheon]

The Manpage for podman machine set says for the --disk-size option: "Only supported for QEMU machines" - so it seems expected that it does not work on Mac. The bug would be that we're allowing this without an error.

@baude Is this a possible feature request, or do the Mac virtualization providers not allow growing images?

[github-actions]

A reviewer has determined we need more information to understand the reported issue. A comment on what is missing should be provided. Be certain you:

• provide an exact reproducer where possible
• verify you have provided all relevant information - minimum is podman info
• answer any follow up questions

If no response to the needs-info is provided in 30 days, this issue may be closed by our stale bot.

For more information on reporting issues on this repository, consult our issue guide.

[baude]

@mheon you caught me in the middle of triaging this myself. I agree the reporter needs to fill in some details, but taking a guess here on what the reporter means. I think the following sort of points it out.

1. Create a machine with a disk (say 20G)

bbaude@bbaude-mac ~ % podman machine init --disk-size 20

2. Start the machine
3. Check the actual disk size in the host fs

bbaude@bbaude-mac ~ % ls -lh ~/.local/share/containers/podman/machine/applehv/podman-machine-default-arm64.raw
-rw-r--r--@ 1 bbaude  staff    20G Apr 16 15:05 /Users/bbaude/.local/share/containers/podman/machine/applehv/podman-machine-default-arm64.raw

4. Check what the guest sees

bbaude@bbaude-mac ~ % podman machine ssh df -h
Filesystem                            Size  Used Avail Use% Mounted on
/dev/vda4                              20G  2.5G   17G  13% /sysroot

5. Stop the machine
6. Increase the disk size

bbaude@bbaude-mac ~ % podman machine set --disk-size 50

7. Check what the host sees

bbaude@bbaude-mac ~ % !ls
ls -lh ~/.local/share/containers/podman/machine/applehv/podman-machine-default-arm64.raw
-rw-r--r--@ 1 bbaude  staff    50G Apr 16 15:08 /Users/bbaude/.local/share/containers/podman/machine/applehv/podman-machine-default-arm64.raw

8. Start the machine
9. Check what the guest sees

Machine "podman-machine-default" started successfully
bbaude@bbaude-mac ~ % podman machine ssh df -h
Filesystem                            Size  Used Avail Use% Mounted on
/dev/vda4                              20G  2.5G   17G  13% /sysroot

Note the filesystem has not increased though the raw disk has.

If you podman machine ssh, you can see that the disk is in fact 50G. And there are basically 30G of free space at the end of the disk. The free space would need to be added to the /dev/vda4 (root) and then of course xfs_growfs /dev/vda4.

core@localhost:~$ sudo fdisk -l
GPT PMBR size mismatch (41943039 != 104857599) will be corrected by write.
The backup GPT table is not on the end of the device.
Disk /dev/vda: 50 GiB, 53687091200 bytes, 104857600 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 5320C3BC-150B-4A65-BE5B-80E395532F29

Device       Start      End  Sectors  Size Type
/dev/vda1     2048     4095     2048    1M Linux reserved
/dev/vda2     4096   264191   260096  127M EFI System
/dev/vda3   264192  1050623   786432  384M Linux filesystem
/dev/vda4  1050624 41943006 40892383 19.5G Linux filesystem

I'm not sure how we automate this short of having a systemd service that checks this on boot and does this but I also think reboots to get the partition table in the kernel correctly (at least that used to be the case) ?

[baude]

Disclaimer: USE AT YOUR OWN RISK

@milafrerichs one thing you can do manually for now is:

core@localhost:~$ sudo growpart /dev/vda 4
CHANGED: partition=4 start=1050624 old: size=40892383 end=41943006 new: size=103806943 end=104857566
core@localhost:~$ sudo mount -o remount,rw /sysroot
core@localhost:~$ sudo xfs_growfs -d /sysroot/
meta-data=/dev/vda4              isize=512    agcount=15, agsize=360320 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=1, rmapbt=1
         =                       reflink=1    bigtime=1 inobtcount=1 nrext64=1
data     =                       bsize=4096   blocks=5111547, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=102600, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0
data blocks changed from 5111547 to 12975867

You might have to reboot to get /sysroot back to ro.

[baude]

@milafrerichs also, can you confirm I am interpreting your issue correctly?

[mheon]

For context from a conversation between @baude and I, it seems like the line in the manpages about this being unsupported is in error; we do expect it to work.