Update all Pinned field references to use VolumeState

Author: tobwen

libpod/options.go

@@ -1761,7 +1761,7 @@ func WithVolumePinned() VolumeCreateOption {
 			return define.ErrVolumeFinalized
 		}
 
-		volume.config.Pinned = true
+		volume.state.Pinned = true
 
 		return nil
 	}

libpod/volume.go

@@ -289,7 +289,14 @@ func (v *Volume) UsesVolumeDriver() bool {
 // Pinned returns whether this volume is marked as pinned.
 // Pinned volumes are excluded from system prune operations by default.
 func (v *Volume) Pinned() bool {
-	return v.config.Pinned
+	v.lock.Lock()
+	defer v.lock.Unlock()
+
+	if err := v.update(); err != nil {
+		return false
+	}
+
+	return v.state.Pinned
 }
 
 // SetPinned sets the pinned status of the volume.
@@ -306,7 +313,7 @@ func (v *Volume) SetPinned(pinned bool) error {
 		return err
 	}
 
-	v.config.Pinned = pinned
+	v.state.Pinned = pinned
 
 	return v.save()
 }

libpod/volume_inspect.go

@@ -75,7 +75,7 @@ func (v *Volume) Inspect() (*define.InspectVolumeData, error) {
 		data.Timeout = v.runtime.config.Engine.VolumePluginTimeout
 	}
 
-	data.Pinned = v.config.Pinned
+	data.Pinned = v.state.Pinned
 
 	return data, nil
 }