Skip to content

Commit 5ab18b0

Browse files
committed
Fix: Rootless Podman-in-Podman on WSL
closes: #27411 Adjust SUB_UID and SUB_GID ranges to support running rootless Podman inside a rootless run Podman container. Also add a test to verify the change and prevent regression. By default, a new user is assigned the following sub-ID ranges: SUB_UID_MIN=100000, SUB_GID_MIN=100000, SUB_UID_COUNT=65536, SUB_GID_COUNT=65536 This means the user’s sub-UID and sub-GID ranges are 100000–165535. When the container is run rootless with the user defined below, ID mappings occur as follows: - Container ID 0 (root) maps to user ID 1000 on the host (which is the user created below). - Container IDs 1–65536 map to IDs 100000–165535 on host (the subid range previously mentioned). If a new user is created inside this container (to build containers for example), it will attempt to use the default sub-ID range (100000–165535). However, this exceeds the container’s available ID mapping, since only IDs up to 65536 are mapped. This causes nested rootless Podman to fail. To enable container-in-container builds, the sub-ID ranges for the user must be large enough to provide at least 65536 usable IDs. A minimum SUB_UID_COUNT and SUB_GID_COUNT of 165536 is required, but 1,000,000 is used here to provide additional margin. 1,000,000 matches the subid range other machines are using, defined in [ignition.go](https://github.com/containers/podman/blob/69b397af49acd595b8d5b36971988d49951c043a/pkg/machine/ignition/ignition.go#L284-L289). The script of other machines modify the subid files directly for 1 user, the `sed` command used in this fix mimics that. The test is added as en extension to the 'simple init with username' test case, to prevent having to create a new VM. Signed-off-by: dvorst <[email protected]>
1 parent ac3a9f8 commit 5ab18b0

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed

pkg/machine/e2e/init_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,30 @@ var _ = Describe("podman machine init", func() {
257257
Expect(err).ToNot(HaveOccurred())
258258
Expect(sshSession).To(Exit(0))
259259
Expect(sshSession.outputToString()).To(ContainSubstring("yes"))
260+
261+
/* Validate that subid count is sufficiently large.
262+
* The subid and subgid files contain a line for each user with subid start and count,
263+
* separated by a double colon, for example: 'user:100000:65536'. Only the count is of
264+
* interest here, it should be sufficiently large to accommodate nested namespaces which is
265+
* required to run rootless Podman in Podman. The check assumes there is only 1 user.
266+
*/
267+
count_min := 1000000
268+
for _, file := range []string{"/etc/subuid", "/etc/subgid"} {
269+
cmd := fmt.Sprintf(`awk -F: 'NR==1 {print $NF}' %s`, file)
270+
sshSession, err := mb.setName(mb.name).setCmd(ssh.withSSHCommand([]string{cmd})).run()
271+
Expect(err).ToNot(HaveOccurred())
272+
Expect(sshSession).To(Exit(0))
273+
274+
subid_count_str := sshSession.outputToString()
275+
Expect(subid_count_str).ToNot(BeEmpty(), "No subid count found in %s", file)
276+
277+
subid_count, err := strconv.Atoi(subid_count_str)
278+
Expect(err).ToNot(HaveOccurred())
279+
Expect(subid_count).To(BeNumerically(">=", count_min),
280+
"Expected subid count %d to be >= %d in %s",
281+
subid_count, count_min, file,
282+
)
283+
}
260284
})
261285

262286
It("machine init with cpus, disk size, memory, timezone", func() {

pkg/machine/wsl/declares.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ ln -fs /dev/null /etc/systemd/system/systemd-oomd.socket
3434
mkdir -p /etc/systemd/system/systemd-sysusers.service.d/
3535
echo CREATE_MAIL_SPOOL=no >> /etc/default/useradd
3636
adduser -m [USER] -G wheel
37+
sed -ir 's/65536/1000000/' /etc/subuid
38+
sed -ir 's/65536/1000000/' /etc/subgid
3739
mkdir -p /home/[USER]/.config/systemd/[USER]/
3840
chown [USER]:[USER] /home/[USER]/.config
3941
`

0 commit comments

Comments
 (0)