Skip to content

Commit 8b82359

Browse files
committed
skip 2xx check on Oras-py Registry.push response
Signed-off-by: Isabella do Amaral <[email protected]>
1 parent bb445ec commit 8b82359

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

omlmd/helpers.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ def push(
9797
manifest_config=manifest_cfg,
9898
do_chunked=True,
9999
)
100-
self.notify_listeners(PushEvent(result, target, model_metadata))
100+
self.notify_listeners(
101+
PushEvent.from_response(result, target, model_metadata)
102+
)
101103
return result
102104
finally:
103105
if owns_meta_files:

omlmd/listener.py

+6-7
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,12 @@ class Event(ABC):
2828

2929
@dataclass
3030
class PushEvent(Event):
31-
response: requests.Response
31+
digest: str
3232
target: str
3333
metadata: ModelMetadata
3434

35-
@property
36-
def ok(self) -> bool:
37-
return self.response.status_code == 200
38-
39-
def get_digest(self) -> str:
40-
return self.response.headers["Docker-Content-Digest"] if self.ok else ""
35+
@classmethod
36+
def from_response(
37+
cls, response: requests.Response, target: str, metadata: ModelMetadata
38+
) -> "PushEvent":
39+
return cls(response.headers["Docker-Content-Digest"], target, metadata)

tests/test_e2e_model_registry.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class ListenerForModelRegistry(Listener):
4343

4444
def update(self, source: Helper, event: Event) -> None:
4545
if isinstance(event, PushEvent):
46-
self.sha = event.get_digest()
46+
self.sha = event.digest
4747
self.rm = from_oci_to_kfmr(model_registry, event, self.sha)
4848

4949
listener = ListenerForModelRegistry()

0 commit comments

Comments
 (0)