We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In many places strings.Split(remote, ":") is used to split the ip and port. This does not work for ipv6 addresses.
strings.Split(remote, ":")
gvisor-tap-vsock/pkg/services/forwarder/ports.go
Lines 53 to 56 in 9d8e7a5
To make this work with ipv6 addresses net.SplitHostPort should be used, https://pkg.go.dev/net#SplitHostPort. To combine a port with a ip address use net.JoinHostPort, https://pkg.go.dev/net#JoinHostPort
net.SplitHostPort
net.JoinHostPort
The text was updated successfully, but these errors were encountered:
Very good point! ipv6 also deserves e2e tests I guess.
Sorry, something went wrong.
No branches or pull requests
In many places
strings.Split(remote, ":")
is used to split the ip and port. This does not work for ipv6 addresses.gvisor-tap-vsock/pkg/services/forwarder/ports.go
Lines 53 to 56 in 9d8e7a5
To make this work with ipv6 addresses
net.SplitHostPort
should be used, https://pkg.go.dev/net#SplitHostPort.To combine a port with a ip address use
net.JoinHostPort
, https://pkg.go.dev/net#JoinHostPortThe text was updated successfully, but these errors were encountered: