Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests to verify gvisor-tap-vsock works as it should #412

Open
lstocchi opened this issue Oct 29, 2024 · 5 comments
Open

Write tests to verify gvisor-tap-vsock works as it should #412

lstocchi opened this issue Oct 29, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lstocchi
Copy link
Collaborator

We should test if visor-tap-vsock works as expected.
E.g. check if the ports are actually open, if the data sent and received are the same (from small to big data), ...

@gbraad gbraad added enhancement New feature or request help wanted Extra attention is needed labels Oct 29, 2024
@lstocchi
Copy link
Collaborator Author

@evidolob @cfergeau feel free to add some other test ideas to verify it works fine. I still haven't looked deeply at the code so what I wrote came out from a discussion with @gbraad

@gbraad gbraad moved this to Work In Progress in Project planning: crc Oct 30, 2024
@anjannath anjannath moved this from Work In Progress to Todo in Project planning: crc Oct 30, 2024
@cfergeau
Copy link
Collaborator

cfergeau commented Nov 4, 2024

What comes to mind:

#321 is related.
On each platform, we'd want to test enabling/disabling port forwarding from the API, check downloading/uploading, maybe between VM and host, and external data. checking for data corruption would be needed as well (ie run sha1/... on the downloaded/uploaded data).
Maybe the DNS tests could be extended, but there are a few of these already.
Detecting performance regressions would be nice, but this means we always run the same benchmark on the same machine, so it's less convenient to do on the long run.

@evidolob
Copy link
Contributor

evidolob commented Nov 6, 2024

As for me is having ability to actual debug tests is crucial, not only the test itself, but gvproxy. It will make troubleshooting process mush easier.

@cfergeau
Copy link
Collaborator

cfergeau commented Nov 6, 2024

See also #357 and #269

@lstocchi
Copy link
Collaborator Author

As for me is having ability to actual debug tests is crucial, not only the test itself, but gvproxy. It will make troubleshooting process mush easier.

Can you please rephrase it? I'm not sure I got it.
What do you do to debug gvproxy atm? Asking as I never do that so trying to understand what are the difficulties and how to make it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants