Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9+ features #1

Open
10 of 15 tasks
judgej opened this issue Apr 17, 2023 · 0 comments
Open
10 of 15 tasks

Laravel 9+ features #1

judgej opened this issue Apr 17, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@judgej
Copy link
Member

judgej commented Apr 17, 2023

Some nice-to-haves, not all essential.

  • Support PHP Money ^4.0
  • Use PHP enum for ledger type.
  • Use string for accounting_ledgers.type. Database enums are great, but really hard to manage in Laravel.
  • Use anonymous function style migrations.
  • Database migration should use the current date and time (but keep the migrations in the correct order).
  • Add notes about using aliases for the morphed type models.
  • Replace dates casting with casts in the models (dates has been deprecated, and removed for Laravel 10).
  • Fix balance calculations so they cannot accidentally mix currencies.
  • Support Carbon\CarbonImmutable for dates, as that is the new default for Laravel 9+. Use Carbon\CarbonInterface as the common interface.
  • initJournal should take a Money\Currency object to be sure it is valid, and if not supplied, default to the config currency, not hard-coded USD.
  • Fix model needing to be re-fetched after its journal has been initialised before the journal can be seen.
  • The transaction reference object should be a normal polynomial relationship.
  • Unique index on journals to ensure a model does not have multiple journals.
  • Move the migrations out of the autoload src directory.
  • Overhaul the whole readme.
@judgej judgej added the enhancement New feature or request label Apr 17, 2023
@judgej judgej self-assigned this Apr 17, 2023
judgej added a commit that referenced this issue Apr 24, 2023
* Reorder migrations.
* Use big intergers for table keys.
* Remove enum from database (rely on eloquent).
* Laravel 9 style anonymous migrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant