Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support withdrawal address in gentx/ create-validator #244

Open
alpe opened this issue Jan 26, 2022 · 3 comments
Open

Support withdrawal address in gentx/ create-validator #244

alpe opened this issue Jan 26, 2022 · 3 comments
Labels
api_breaking S Small, <1 day work

Comments

@alpe
Copy link
Contributor

alpe commented Jan 26, 2022

We could have the withdrawal-address in the gentx and create-validator msg already.
The process are 2 steps currently where the validator-operator has to set the withdrawal address after the chain is launched.

@ethanfrey
Copy link
Contributor

I think vesting accounts handle this. If I have 100 vesting tokens and you send me 50, those 50 are immediately available to bank send

We need to verify in code and in tests.

@alpe
Copy link
Contributor Author

alpe commented Jan 28, 2022

When I tried to spent rewards while tokens from a vested account were staked, it was not possible.
Only when balance > locked amount, the test passed. This is the sdk code called in send:
https://github.com/cosmos/cosmos-sdk/blob/v0.45.0/x/bank/keeper/send.go#L183

With a withdrawal address the rewards would be accessible

@alpe alpe added this to the Tgrade 0.x - "Post Mainnet" milestone Feb 15, 2022
@alpe
Copy link
Contributor Author

alpe commented Feb 15, 2022

I am moving this to a "post mainnet" milestone to be pulled in when there is enough capacity or be closed. This issue is optimizing a rare use case for the setup phase only

@alpe alpe added the S Small, <1 day work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api_breaking S Small, <1 day work
Projects
None yet
Development

No branches or pull requests

2 participants