Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new privilege raw_events #139

Open
3 tasks
alpe opened this issue Sep 16, 2021 · 6 comments
Open
3 tasks

Add new privilege raw_events #139

alpe opened this issue Sep 16, 2021 · 6 comments
Assignees
Labels
idea idea - not ready to start coding state_breaking

Comments

@alpe
Copy link
Contributor

alpe commented Sep 16, 2021

Background:
With bonding/unboding we have events emitted by the contract and the PoE module's msg_server. There is an amount of duplicate data with this approach. The contract's events are prefixed with wasm- so that they can not replace the ones defined in staking module.

Requires: CosmWasm/wasmd#614

Follow up tasks would be:

  • provide new impl with custom event mapping (rule: reject message type events)
  • add sdk type events to stake contract
  • remove duplicate events from PoE module
@alpe alpe added this to the Tgrade 0.4 milestone Sep 16, 2021
@ethanfrey
Copy link
Contributor

I like the wasmd one.
Sounds like super arcane, boring technical refactoring.

@ethanfrey
Copy link
Contributor

This would be a nice addition to a future staking contract. And really make privileged contracts first class citizens.

@ethanfrey
Copy link
Contributor

I don't see this as urgent. We don't do proper faking of all the staking contracts anyway (use different proto types for messages, etc). We can look at this in the future, for now block explorers seem to work without this

@alpe
Copy link
Contributor Author

alpe commented Jul 7, 2022

This was a very old idea to be able to fully migrate go modules to contracts. Do you think this is still relevant @daniellarita ?

@daniellarita daniellarita self-assigned this Jul 7, 2022
@daniellarita
Copy link

@ethanfrey what do you think, is this ticket still relevant?

@ethanfrey
Copy link
Contributor

I think the idea is good and it would give better compatibility, but event compatibility didn't seem to be a major issue with tooling.

I would leave this in the "nice ideas" pile, where we could do if there is time for refactoring and polish, but not urgent at all

@alpe alpe added the idea idea - not ready to start coding label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea idea - not ready to start coding state_breaking
Projects
None yet
Development

No branches or pull requests

3 participants