-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ContractInfo
mock querier
#375
Comments
contract_info
mockContractInfo
mock querier
I find it being kind of a conradiction of the typical mocks usages. Typically mocks are configured to return fixed data (possibly configured in test directly). What you are proposing is basically simulating environment and we have it - it is called multitest. Maybe we should consider switching to multitest for those cases? |
I think it would be good to have this for unit tests as well. There's currently CosmWasm/cosmwasm#1050 that introduces a method for doing that, but it's still cumbersome / verbose to use. Let's follow the discussion there, to see if that can be improved. |
I kind of understand you even if I don't fully like idea testing such things in UT instead of MT. However I feel like it is kind of blocked by CosmWasm/cosmwasm#1050 and I am wondering - is it needed for v0.5.3? I would wait with it till the shape of this is well defined in 1050, as tests are actually existing for now. |
Related to #368.
We're currently mocking a querier for
tgrade-trusted-circle
unit tests. As part of it, we're implementing aContractInfo
querier, which returns dummy data. Improve on this by returning "real" (i.e. previosuly stored, or logically defined) data for the contract.Also, consider moving / generalizing this mock querier somewhere / somehow (related to CosmWasm/cosmwasm#1050, and see #368 (comment)).
The text was updated successfully, but these errors were encountered: