Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: run CI for k8s configured with CRI-O #1981

Open
wainersm opened this issue Aug 6, 2024 · 0 comments · May be fixed by #2068
Open

libvirt: run CI for k8s configured with CRI-O #1981

wainersm opened this issue Aug 6, 2024 · 0 comments · May be fixed by #2068
Labels
CI Issues related to CI workflows provider/libvirt

Comments

@wainersm
Copy link
Member

wainersm commented Aug 6, 2024

Recently kata-deploy got support for configuring CRI-O to do guest-pull (kata-containers/kata-containers#9537), and finally CRI-O was added on CoCo operator (confidential-containers/operator#376).

The current CI jobs (on pull and daily) for libvirt are all testing k8s configured with containerd. This issue is to track the work required to test with CRI-O as well.

It seems the major changes will be:
@wainersm wainersm added CI Issues related to CI workflows provider/libvirt labels Aug 6, 2024
@wainersm wainersm mentioned this issue Aug 6, 2024
Open
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Sep 27, 2024
@wainersm
libvirt/kcli_cluster.sh: add support to CRI-O
71b2c67 
By exporting the CONTAINER_RUNTIME=crio variable, kcli will create
a k8s cluster configured CRI-O:

$ export CONTAINER_RUNTIME=crio
$ ./src/cloud-api-adaptor/libvirt/kcli_cluster.sh create

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Sep 27, 2024
@wainersm
test/e2e: new container_runtime property for libvirt
1a91d70 
Commit a0247ae introduced a new parameter (CONTAINER_RUNTIME) for docker
provider, allowing users to specify the container runtime used. Some tests will
take decisions based on that property, for example, whether nydus snapshotter
messages should be inspected or not. This added the handler for that property
for libvirt, so that peer-pods be tested with cri-o too.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Sep 27, 2024
@wainersm
workflows/libvirt: add e2e job to test with CRI-O
ec93510 
Added a new container_runtime matrix column to generate
one job for each runtime: containerd and crio.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Sep 27, 2024
@wainersm
workflows/libvirt: allow the e2e crio job to fail
b8dd9f3 
Let's keep it running for a while on CI, once it's stable we can
remove the continue-on-error.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
@wainersm wainersm linked a pull request Sep 27, 2024 that will close this issue
Open
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 3, 2024
@wainersm
libvirt/kcli_cluster.sh: add support to CRI-O
2af368a 
By exporting the CONTAINER_RUNTIME=crio variable, kcli will create
a k8s cluster configured CRI-O:

$ export CONTAINER_RUNTIME=crio
$ ./src/cloud-api-adaptor/libvirt/kcli_cluster.sh create

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 3, 2024
@wainersm
test/e2e: new container_runtime property for libvirt
710b05b 
Commit a0247ae introduced a new parameter (CONTAINER_RUNTIME) for docker
provider, allowing users to specify the container runtime used. Some tests will
take decisions based on that property, for example, whether nydus snapshotter
messages should be inspected or not. Likewise, this added the handler for that
property for libvirt, so allowing to test with cri-o too.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 3, 2024
@wainersm
workflows/libvirt: add e2e job to test with CRI-O
45629a0 
Added a new container_runtime matrix column to generate
one job for each runtime: containerd and crio.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 3, 2024
@wainersm
workflows/libvirt: allow the e2e crio job to fail
a33d3aa 
Let's keep it running for a while on CI, once it's stable we can
remove the continue-on-error.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
@wainersm wainersm mentioned this issue Oct 8, 2024
Open
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 8, 2024
@wainersm
libvirt/kcli_cluster.sh: add support to CRI-O
c179d8c 
By exporting the CONTAINER_RUNTIME=crio variable, kcli will create
a k8s cluster configured CRI-O:

$ export CONTAINER_RUNTIME=crio
$ ./src/cloud-api-adaptor/libvirt/kcli_cluster.sh create

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 8, 2024
@wainersm
test/e2e: new container_runtime property for libvirt
dc89125 
Commit a0247ae introduced a new parameter (CONTAINER_RUNTIME) for docker
provider, allowing users to specify the container runtime used. Some tests will
take decisions based on that property, for example, whether nydus snapshotter
messages should be inspected or not. Likewise, this added the handler for that
property for libvirt, so allowing to test with cri-o too.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 8, 2024
@wainersm
workflows/libvirt: add e2e job to test with CRI-O
8a12b1a 
Added a new container_runtime matrix column to generate
one job for each runtime: containerd and crio.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
wainersm added a commit to wainersm/cc-cloud-api-adaptor that referenced this issue Oct 8, 2024
@wainersm
workflows/libvirt: allow the e2e crio job to fail
0931173 
Let's keep it running for a while on CI, once it's stable we can
remove the continue-on-error.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Issues related to CI workflows provider/libvirt
Projects
CoCo Releases
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: run e2e tests for libvirt with CRI-O wainersm/cc-cloud-api-adaptor
1 participant
@wainersm