Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block BS5 css class for <select /> should be form-select #4

Open
petschki opened this issue Apr 19, 2023 · 4 comments
Open

Block BS5 css class for <select /> should be form-select #4

petschki opened this issue Apr 19, 2023 · 4 comments

Comments

@petschki
Copy link

See: https://github.com/conestack/yafowil.bootstrap/blob/2.0/src/yafowil/bootstrap/bs5.py#L57 ... I wanted to update the PR but could not ... @rnixx may I have access ?
@petschki petschki changed the title Block css class for <select /> should be form-select Block BS5 css class for <select /> should be form-select Apr 19, 2023
@rnixx
Copy link
Member

rnixx commented Apr 25, 2023

Hi, I've sent you an invitation.

We should update the resources as well -> https://github.com/conestack/yafowil.bootstrap/tree/2.0/src/yafowil/bootstrap/resources/bs5

@petschki
Copy link
Author

petschki commented Apr 25, 2023 •
edited
Loading

Thanks! Invitation accepted. I will update the PR later this week.

@petschki
Copy link
Author

PR Updated ... exactly one year later 😂

Should we release this state as beta maybe?

@petschki
Copy link
Author

hm ... let me first update the resources to latest BS 5.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnixx @petschki