Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Acknowledging all the tasks is incorrect #341

Open
shrimank opened this issue Dec 17, 2024 · 0 comments
Open

[BUG] Acknowledging all the tasks is incorrect #341

shrimank opened this issue Dec 17, 2024 · 0 comments

Comments

@shrimank
Copy link

shrimank commented Dec 17, 2024

As the code line highlighted above could lead to some of the tasks put in progress without being polled by the worker.

My Use case:
I have parallel tasks which are being created dynamically in FORK_JOIN_DYNAMIC, here my worker is not a batch processor, it just polls only a single task and marks it as IN PROGRESS, due the above logic, my worker is able to poll one task and other task are NOT being polled as the above line marks all the task as ackTaskRecieved, which I believe is not correct.

we should have some flag kind of thing, based on that acking all the tasks make sense, instead of acking all the tasks from the queue blindly.

Open for suggestions ?
@[email protected]

@shrimank shrimank changed the title Acknowledging all the tasks is incorrect [BUG] Acknowledging all the tasks is incorrect Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant