Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] mpdecimal/2.5.1: Extra dependency on automake for MSVC builds #25803

Open
StingX84 opened this issue Nov 2, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@StingX84
Copy link

StingX84 commented Nov 2, 2024

Description

The package sets dependence on "Autoconf" and "Msys2" for MSVC, although only NMAKE is used during build.

The function that determines the dependence at the current moment:

    def build_requirements(self):
        if is_msvc(self):
            self.tool_requires("automake/1.16.5")
        else:
            # required to support windows as a build machine
            if self._settings_build.os == "Windows":
                self.win_bash = True
                if not self.conf.get("tools.microsoft.bash:path", check_type=str):
                    self.tool_requires("msys2/cci.latest")

But can be perfectly simplified to:

    def build_requirements(self):
        # required to support windows as a build machine
        if not is_msvc(self) and self._settings_build.os == "Windows":
            self.win_bash = True
            if not self.conf.get("tools.microsoft.bash:path", check_type=str):
                self.tool_requires("msys2/cci.latest")

With this configuration, everything builds without any problem and extra large dependencies.

Package and Environment Details

  • Package Name/Version: mpdecimal/2.5.1
  • Operating System+version: Windows 11
  • Compiler+version: Visual Studio 2022
  • Conan version: conan 1.65.0
  • Python version: Python 3.9.13

Conan profile

[settings]
os=Windows
os_build=Windows
arch=x86_64
arch_build=x86_64
compiler=Visual Studio
compiler.runtime=MDd
compiler.version=17
compiler.toolset=v143
build_type=Debug
[options]
[build_requires]
[env]

Steps to reproduce

conan info -b * mpdecimal/2.5.1@

Logs

Click to expand log
mpdecimal/2.5.1: Forced build from source
m4/1.4.19: Forced build from source
autoconf/2.72: Forced build from source
automake/1.16.5: Forced build from source
msys2/cci.latest: Forced build from source
msys2/cci.latest, m4/1.4.19, autoconf/2.72, automake/1.16.5, mpdecimal/2.5.1
@StingX84 StingX84 added the bug Something isn't working label Nov 2, 2024
@StingX84 StingX84 changed the title [package] mpdecimal/2.5.1: Extra dependency on autoconf and msys2 for MSVC builds [package] mpdecimal/2.5.1: Extra dependency on autoconf for MSVC builds Nov 2, 2024
@StingX84 StingX84 changed the title [package] mpdecimal/2.5.1: Extra dependency on autoconf for MSVC builds [package] mpdecimal/2.5.1: Extra dependency on automake for MSVC builds Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant