-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] V2 migration linter - checks to add #11393
Comments
I would say conan-io/hooks#387 is related. Adding set_property would be great too. |
Whatever can be easily fixed by any contributor seeing the error, it is more than welcome. Anyone should feel free to suggest the changes to the linter, the PR will validate how many recipes are broken given the new check and the merge might be blocked if there are too many errors. |
I guess this issue can be closed. The most basic check is no imports from conans.* and then let's see if 2.0 CI succeeds. Otherwise this is more an issue for the hooks repository, right? |
@uilianries Can probably close this one as well. |
now we have V2 migration linter (#11147), it's time to think about useful checks to add.
we definetely don't want to add too broad checks like
replace "import conans" via "import conan"
, as it basically means "rewrite the whole recipe".I personally guess we should start from small things, which are easy to check and fix.
a good candidates where should we start could be:
from what I can currently recommend, we may try to implement the following pieces first:
from conan.errors import ConanInvalidConfiguration
,from conan import ConanFile
, with higher granulartyrun_environment=True
viaenv="conanrun"
(VirtualRunEnv
generator)self.info
inpackage_id
method instead of justself
conan.tools
instead ofconan.tools
, with higher granularity - code changes are mostly to add firstself
argument, but they are in different namespaces nowbuild_requires
viatool_requires
test_type
anything else?
The text was updated successfully, but these errors were encountered: