BF: force "little" endianness while xor_byte #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using xor_byte for fingerprint computation and need to also handle bytes of different length. When working on big-endian platforms (such as the only one left s390x on debian) our assumptions of alignment of bytes in such strings fail. For consistency - always do it "little endian" way
yarikoptic
added
patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 92.06% 92.07% +0.01%
==========================================
Files 4 4
Lines 529 530 +1
Branches 40 40
==========================================
+ Hits 487 488 +1
Misses 25 25
Partials 17 17 ☔ View full report in Codecov by Sentry. |
jwodder
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using xor_byte for fingerprint computation and need to
also handle bytes of different length. When working on big-endian
platforms (such as the only one left s390x on debian) our assumptions
of alignment of bytes in such strings fail. For consistency - always
do it "little endian" way
I also added "testing" for the expectation of the target value, so easy to discern desired logic for xor'ed value construction.
Closes #101