Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sample timing #197

Open
asmacdo opened this issue Oct 3, 2024 · 0 comments
Open

Improve sample timing #197

asmacdo opened this issue Oct 3, 2024 · 0 comments

Comments

@asmacdo
Copy link
Member

asmacdo commented Oct 3, 2024

Currently, report interval is implemented by checking whether the absolute time, but Sample interval is implemented with a what is essentially a sleep(sample_interval).

This causes the actual sample interval to be higher by the amount of time it takes to collect the sample.

https://github.com/con/duct/blob/main/src/con_duct/__main__.py#L834

Additionally for a single sample collection we are calculating the timestamps multiple times (one for each process) which is not accurate--all of that data is collected in a single measurement and should have exactly the same timestamp.

https://github.com/con/duct/blob/main/src/con_duct/__main__.py#L454

_Originally posted by @yarikoptic in #182 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant