-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A5_A3 get_peptide_sequence.py associates same TPMs to different samples #5
Comments
Hi, Yes, this seems a bug indeed. I have changed it accordingly and quickly tested it and it seems to go smooth. Could you test it as well? I created a new branch to test this. Thanks for your help. Best regards, Juanlu. |
Hi, thanks for your feedback! I just tested it but it rises the error: I added Thank you, |
Thanks,
I've added those lines in the code of the master
I've also merged the other fixes.
I hope it is fine now
Thanks
E.
…On Fri, 20 May 2022 at 22:04, FraPria ***@***.***> wrote:
Hi, thanks for your feedback!
I just tested it but it rises the error:
2022-05-20 13:54:04,566 - lib.A5_A3.get_peptide_sequence - ERROR - ERROR:
NameError("name 'sample_id' is not defined")
I added
sample_id = tokens[0].replace(" ","")
at the lines 253 and 1005 and it worked.
Thank you,
have a nice day!
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCZKB5TTFKVLNDNK2PTYJLVK55WFANCNFSM5WFIVMTQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Prof. E Eyras
EMBL Australia Group Leader
The John Curtin School of Medical Research - Australian National University
https://github.com/comprna
http://scholar.google.com/citations?user=LiojlGoAAAAJ
|
Hello, thank you for developing this useful pipeline!
I have a technical question that I would like to address you.
I noticed from the file file A5_A3_NetMHC-4.0_junctions_ORF_neoantigens.tab that samples that share the same event share also the same Transcript_TPM.
You can see it from the header of the file (selecting only columns of interest):
While if you select the same transcript from iso_tpms.txt matrix they are different.
This seems to rise from line 136 of
lib/A5_A3/get_peptide_sequence.py
where it takes only the first column of the iso_tpms.txt matrix:So I tested if swapping the columns of iso_tpms.txt could change the results and it did.
For the other events this does not happen, and the code is a bit different. For example for the Exonizations it considers all the iso_tpms.txt columns:
Should I use this piece of code also for the A5_A3?
Thank you in advance
The text was updated successfully, but these errors were encountered: