Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsense plugin breaks spinner animation #13

Open
geckolinux opened this issue Dec 28, 2014 · 5 comments
Open

Adsense plugin breaks spinner animation #13

geckolinux opened this issue Dec 28, 2014 · 5 comments

Comments

@geckolinux
Copy link

Hello, this plugin breaks the spinner animation on Discourse.

https://meta.discourse.org/t/suggested-topics-displayed-as-en-undefined/23415/7?u=sb56637

I'm on Discourse 1.2.0.beta4, and I believe this breakage is new to beta4.

@thangngoc89
Copy link
Contributor

Nope. It was there since a commit on beta 3.

@bartv42
Copy link

bartv42 commented Feb 4, 2015

Any updates? This one's bothering me as well.

@thangngoc89
Copy link
Contributor

@bartv42 I created a pull request here to fix it in 1.2.0beta4. You can use it if you want
#14

@bartv42
Copy link

bartv42 commented Feb 4, 2015

Thanks, but I'm not too technical. I'll wait for it to appear in a future update, but it's good to hear it's been fixed!

@thangngoc89
Copy link
Contributor

@bartv42 I created this pull request 24 days ago. but no reply or anything. If you want to fix it right now. You can change from Discoursehosting repo to my : https://github.com/thangngoc89/discourse-adsense (in app.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants