We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems like the operations with attribute p0 are not congruent/correct.
p0
From the first short review: sometimes to calculate the unlocked tokens the contract multiplies with p0 and sometimes divides.
Example:
fundsAllocated() { unlockedInternal += _externalAllocated / p0;
claimTokens() { uint256 previouslyUnlockedInternal = (paidExternal / p0)
hatchContribute() { initialContributions[msg.sender].lockedInternal += contributed * p0;
I think it works only by accident given the p0 is 1 by default. Would be great to review the math here.
The text was updated successfully, but these errors were encountered:
Fixes:
lightstreams-network#5 lightstreams-network#9
Sorry, something went wrong.
What has lightstreams-network#9 to do with this issue?
42a601b Fix
No branches or pull requests
It seems like the operations with attribute
p0
are not congruent/correct.From the first short review: sometimes to calculate the unlocked tokens the contract multiplies with p0 and sometimes divides.
Example:
I think it works only by accident given the p0 is 1 by default. Would be great to review the math here.
The text was updated successfully, but these errors were encountered: