Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some state update functions do too many things, consider refactor #1

Open
randomshinichi opened this issue Jul 8, 2020 · 0 comments
Open

Some state update functions do too many things, consider refactor #1

randomshinichi opened this issue Jul 8, 2020 · 0 comments

Comments

@randomshinichi
Copy link
Collaborator

add_participants_proposals_to_network() actually does two things

  1. If the policy has decided to add something a new Participant and/or Proposal to the network, do so.
  2. Update the age of existing Proposals and the conviction voting trigger threshold for each (since it depends on Age).

This is not the only state update function that has too many responsibilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@randomshinichi