Skip to content

Conversation

@rohit9625
Copy link
Collaborator

Description (required)

Fixes #6549

What changes did you make and why?

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@rohit9625
Copy link
Collaborator Author

Waiting for #6571 to be fixed first.

@RitikaPahwa4444
Copy link
Collaborator

Can't wait to test this out. @rohit9625 the issue you linked has been closed, is this still a work-in-progress PR?

@rohit9625
Copy link
Collaborator Author

Yes, it's still in progress, and I'm stuck at something. Also, the only way to the solve problem permanently is to implement something like we have in our normal gallery apps. Because, no matter what the icons color be(dark or light), it can always get hidden if the image has the same color.
So, I created a trasparent scrim at the top inspired from Gallery App on my Samsung mobile. It's just that I want to allow users to hide the system bars and enter immersive mode when user click on the image. Due to scrim color, the status bar icons always will be visible.

Currently, we have other gestures for image and that's why single tap gesture seems to be overlapping with others. I'll find out a fix for that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OS notification/time bar barely visible in some activities

2 participants