Skip to content

Commit 4110cda

Browse files
committed
Version 2.5.2: debugging for failed asset file logging
1 parent 67317fe commit 4110cda

File tree

2 files changed

+23
-5
lines changed

2 files changed

+23
-5
lines changed

cometx/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212
# the express permission of Comet ML Inc.
1313
# *******************************************************
1414

15-
version_info = (2, 5, 1)
15+
version_info = (2, 5, 2)
1616
__version__ = ".".join(map(str, version_info))

cometx/cli/copy.py

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,7 +1161,10 @@ def update_datagrid_contents(
11611161
step,
11621162
log_as_filename,
11631163
)
1164-
asset_map[old_asset_id] = result["assetId"]
1164+
if result is None:
1165+
print(f"ERROR: Unable to log asset {log_as_filename}; skipping")
1166+
else:
1167+
asset_map[old_asset_id] = result["assetId"]
11651168

11661169
def _log_asset(
11671170
self, experiment, path, asset_type, log_filename, assets_metadata, asset_map
@@ -1255,7 +1258,12 @@ def _log_asset(
12551258
step,
12561259
log_as_filename or log_filename,
12571260
)
1258-
asset_map[old_asset_id] = result["assetId"]
1261+
if result is None:
1262+
print(
1263+
f"ERROR: Unable to log asset {log_as_filename or log_filename}; skipping"
1264+
)
1265+
else:
1266+
asset_map[old_asset_id] = result["assetId"]
12591267
elif asset_type == "datagrid":
12601268
self.update_datagrid_contents(
12611269
experiment,
@@ -1290,7 +1298,12 @@ def _log_asset(
12901298
step,
12911299
log_as_filename or log_filename,
12921300
)
1293-
asset_map[old_asset_id] = result["assetId"]
1301+
if result is None:
1302+
print(
1303+
f"ERROR: Unable to log asset {log_as_filename or log_filename}; skipping"
1304+
)
1305+
else:
1306+
asset_map[old_asset_id] = result["assetId"]
12941307
elif asset_type == "video":
12951308
name = os.path.basename(filename)
12961309
binary_io = open(filename, "rb")
@@ -1311,7 +1324,12 @@ def _log_asset(
13111324
step,
13121325
log_as_filename or log_filename,
13131326
)
1314-
asset_map[old_asset_id] = result["assetId"]
1327+
if result is None:
1328+
print(
1329+
f"ERROR: Unable to log asset {log_as_filename or log_filename}; skipping"
1330+
)
1331+
else:
1332+
asset_map[old_asset_id] = result["assetId"]
13151333

13161334
def log_assets(self, experiment, path, assets_metadata):
13171335
if self.debug:

0 commit comments

Comments
 (0)