Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluator commands duff out/mill-chrome-profile.json #3879

Open
lefou opened this issue Oct 31, 2024 · 3 comments
Open

Evaluator commands duff out/mill-chrome-profile.json #3879

lefou opened this issue Oct 31, 2024 · 3 comments

Comments

@lefou
Copy link
Member

lefou commented Oct 31, 2024

Evaluator commands make the out/mill-chrome-profile.json un-useful since they seem to overwrite it.

Here is an example, where idea is a customized derivate of mill.idea.GenIdea/idea.

While the command is still running, I can see a partially filled out/mill-chrome-profile.json with lots of details:

image

But after the command finishes, the out/mill-chrome-profile.json looks less useful:

image

@lihaoyi
Copy link
Member

lihaoyi commented Oct 31, 2024

Maybe every time we open mill-chrome-profile.json, we should check if one exists, and if one does then open mill-chrome-profile-2.json mill-chrome-profile-3.json etc.. We can wipe out all mill-chrome-profile*.jsons at the start of each run. This would ensure that all profiles are saved, even if multiple evaluation runs are started re-entrantly

The same should probably be done for the other mill-* debug files, mostly mill-profile.json I think

@lefou
Copy link
Member Author

lefou commented Oct 31, 2024

I think this is because evaluator command use dedicated evaluator instances which don't use the outer profile logger. Instead, we could pass the profile logger around.

@lihaoyi
Copy link
Member

lihaoyi commented Oct 31, 2024

oh yeah that's also an option. Then the same profile would show tasks from all evaluations, which would be even better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants