You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The optimisation introduced in #1067 and specifically the if clause in colour.utilities.tsplit definition is causing some grief.
Transposition is done by flipping some flags in Numpy, thus in the case of 1D and 2D arrays, a different view rather than a copy of the input data is returned. The consequence is that the arrays returned by colour.utilities.tsplit are sometimes non-contiguous and it is causing issues with OCIO.
Another problem, which is arguably worse is that this sometimes causes the data passed to our functions to be modified in-place: Before, colour.utilities.tsplit was always returning a copy of the data, but now this is not always guaranteed . Earlier, as I was checking the unit tests of colour.difference.delta_E_ITP definition, I noticed that we did not have the multi-dimensional test cases. I decided to add them and they did not pass for some really odd reasons. It turns out that [this line] (
Description
The optimisation introduced in #1067 and specifically the if clause in
colour.utilities.tsplit
definition is causing some grief.Transposition is done by flipping some flags in Numpy, thus in the case of 1D and 2D arrays, a different view rather than a copy of the input data is returned. The consequence is that the arrays returned by
colour.utilities.tsplit
are sometimes non-contiguous and it is causing issues with OCIO.Another problem, which is arguably worse is that this sometimes causes the data passed to our functions to be modified in-place: Before,
colour.utilities.tsplit
was always returning a copy of the data, but now this is not always guaranteed . Earlier, as I was checking the unit tests ofcolour.difference.delta_E_ITP
definition, I noticed that we did not have the multi-dimensional test cases. I decided to add them and they did not pass for some really odd reasons. It turns out that [this line] (colour/colour/difference/delta_e.py
Line 559 in 9c36d3b
Code for Reproduction
Expected:
Exception Message
Environment Information
The text was updated successfully, but these errors were encountered: