Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warped perspective feature, splitting the segmentation into segmenter and extractor (Issue #60) #76

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

TimWalter
Copy link

@TimWalter TimWalter commented Mar 9, 2024

Summary

This pull request implements the issue #60 . This adds functionality for colour to detect checkers photographed at various distances and even if they are not facing the camera straight. To this end further clustering techniques are employed. Moreover, central to the approach is the definition of Templates that encode the inherent swatch structure of the checker, which is utilized to derive promising correspondences of swatches that would yield a correct transformation. Among these correspondences the best transformation is determined by brute force. However, a greedy heuristic is deployed to stop the search early, if a suitable transformation has been found.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@TimWalter
Copy link
Author

No idea whats wrong with the checks

@KelSolaar
Copy link
Member

Thanks a lot @TimWalter!

I will take a serious look after GDC.

At first glance, I think we will need to modify the inference method to also use an extractor for consistency.

correct_flipped might have issues with the ColourChecker SG, I think it would be better to compare the R/MSE of the current swatch colours to that of the reference one and we flip until we get the lowest value. We do that here: https://github.com/colour-science/colour-checker-detection/blob/develop/colour_checker_detection/detection/common.py#L1149

@KelSolaar
Copy link
Member

Hey @TimWalter,

This is still very much on my radar, I just have a ton of stuff to wrangle with more priority than this, it will be merged!

Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants