chore: upgrade to eslint 9.x #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades ESLint and moves to the new flat config style. Also fixes up some newly found lint errors/warnings and enables TSESLint's strict config.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
43081j
commented
Dec 27, 2024
| @@ -202,7 +203,7 @@ export default class Notebook { | |||
| } | |||
| catch (e) { | |||
| // Syntax error | |||
| var error = e; | |||
There was a problem hiding this comment.
I feel like there may have been a reason this used var. let me know if we cant make this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ESLint and moves to the new flat config style.
Also fixes up some newly found lint errors/warnings and enables TSESLint's strict config.
I was roaming around the repo so figured I'd do this while I'm in there. if you don't want it, all good just let me know and we can close this 👍
Notes
npm run build:tsfails with a lot of errors. is that known to be broken? (inmain)