Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming "View" buttons #3356

Open
midimusicman79 opened this issue Nov 17, 2022 · 2 comments
Open

Consider renaming "View" buttons #3356

midimusicman79 opened this issue Nov 17, 2022 · 2 comments
Labels
web front-end user interface

Comments

@midimusicman79
Copy link

In Mozilla Firefox, on page 33, or in Google Chrome, on page 31, in the FilterLists:

Upon clicking the blue information button for the Disconnect Malvertising Filter List and clicking the View link, it does NOT display the filter list as clear text in the web browser but instead opens a download window.

However, doing the same with all the other three similar filter lists from Disconnect, such as the Disconnect Advertising Filter List, the Disconnect Malware Filter (Domains), and the Disconnect Tracking Filter List, DOES display the filter lists.

I am using uBlock Origin, and just as a test, I temporarily managed to subscribe to the Disconnect Malvertising Filter List, but I thought I would report this issue anyway.

@collinbarrett
Copy link
Owner

collinbarrett commented Nov 17, 2022

For the specific list you are referencing, this issue would need to be discussed with the Disconnect team as they own the resources at those URLs we link to. It appears to be that the Content-Type response header might be what is causing the different behavior between the Disconnect lists.

That being said, we might want to consider renaming the buttons on FilterLists.com from "View" to some other word that better indicates "View" or "Download"...

@collinbarrett collinbarrett changed the title The Disconnect Malvertising Filter List View link does NOT display the filter list but instead opens a download window. Consider renaming "View" buttons Nov 17, 2022
@collinbarrett collinbarrett added the web front-end user interface label Nov 17, 2022
@midimusicman79
Copy link
Author

Thank you, and that sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web front-end user interface
Projects
None yet
Development

No branches or pull requests

2 participants