Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8 #9

Closed
wants to merge 1 commit into from
Closed

Issue 8 #9

wants to merge 1 commit into from

Conversation

rodfersou
Copy link
Member

  • Added fixes explained into issue 8.
  • Fix slideshare tests.

closes #8

* Fix slideshare tests.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b9ec717 on issue_8 into * on master*.

@hvelarde
Copy link
Member

first, I think we must focus on WCAG 2.0 only:

WCAG 2.0 succeeds Web Content Accessibility Guidelines 1.0, which was published as a W3C Recommendation May 1999. Although it is possible to conform either to WCAG 1.0 or to WCAG 2.0 (or both), the W3C recommends that new and updated content use WCAG 2.0. The W3C also recommends that Web accessibility policies reference WCAG 2.0.

second, I'm not sure what's the best approach here.

I tested 4 of the most important providers (SlideShare, SoundCloud, Vimeo and YouTube); all of them use an iframe, all of them include a title in the iframe and all of them provide an alternate link for browsers/devices not supporting the iframe tag.

as you can enter any code on the embed_html field I think we must only show a warning message after the user has saved the object; this way you'll give the opportunity to fix it.

for the WC3 fixes, obviously I did not explain myself it clearly: I never mend to remove the attributes from external code, just from our own templates.

see https://github.com/simplesconsultoria/sc.embedder/blob/master/src/sc/embedder/content/templates/embeddervideojs.pt#L54

enforcing content for WCAG 2.0 compliance is going to be harder and is the scope of a different package, IMO (collective.wcgawatchdog?).

@hvelarde hvelarde mentioned this pull request Mar 9, 2015
@hvelarde hvelarde closed this Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix WCGA and W3C validation issues (iframes)
3 participants