Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microformat #44

Open
colbyfayock opened this issue Oct 15, 2020 · 24 comments
Open

Microformat #44

colbyfayock opened this issue Oct 15, 2020 · 24 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@colbyfayock
Copy link
Owner

We should add logical microformats throughout the site

http://microformats.org/
https://microformats.io/
https://developer.mozilla.org/en-US/docs/Web/HTML/microformats

@colbyfayock colbyfayock added enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed labels Oct 15, 2020
@arifsetyo21
Copy link

which part to add microformat?

@colbyfayock
Copy link
Owner Author

hey @arifsetyo21 i'm hoping to add as much coverage as makes sense, so that includes author information, post information, website information. it would be great if as part of this issue, the person who takes it tries to figure out what all make sense

@arifsetyo21
Copy link

Okay, can i do this issue?

@colbyfayock
Copy link
Owner Author

sure thing :) let me know if you have any issues!

@colbyfayock colbyfayock removed the help wanted Extra attention is needed label Oct 18, 2020
@doingandlearning
Copy link
Collaborator

I don't know if this belongs in this issue but it would be good to have everything required for webmentions leveraging of microformats in here.

@doingandlearning
Copy link
Collaborator

(I'll find a link!)

@colbyfayock
Copy link
Owner Author

yes! that was one of the things i had in mind when thinking about it. it would be cool as that information is valuable for services that can provide a rich experience and if im not mistaken even search engines use it

@colbyfayock
Copy link
Owner Author

hey @arifsetyo21 checking in - are you having any luck with this?

@colbyfayock
Copy link
Owner Author

unassigning this to allow someone else to work on it

@Azanul
Copy link

Azanul commented Oct 4, 2022

@colbyfayock I'll take this up if no one else is working on it. Also, I think this issue should be split in two as there could be too many changes at once.

@colbyfayock
Copy link
Owner Author

@Azanul sounds good to me! would love to hear your thoughts then before moving forward including the work that needs to be done and what you see as the 2 issues

@Azanul
Copy link

Azanul commented Oct 9, 2022

@colbyfayock I meant 2 PRs as there can be many changes.

@colbyfayock
Copy link
Owner Author

Got it, I would still like 2 issues to have concise details around the problems each are solving so that we're not creating 2 PRs for the sake of creating 2 PRs

@Azanul
Copy link

Azanul commented Oct 14, 2022

@colbyfayock I've read about microformats now. What I understood is we'll have to add appropriate class names to all components, right?

@colbyfayock
Copy link
Owner Author

from what i understand i think thats part of it. i was also under the impression there would be more attributes than classes, such as "roles" and such, but i haven't looked too deeply into it

@Azanul
Copy link

Azanul commented Oct 14, 2022

@colbyfayock
Copy link
Owner Author

yeah haha that might be it! :D

i trust whatever you find out through your research

@Azanul
Copy link

Azanul commented Oct 14, 2022

Let's divide it in either of these two ways:

  1. per component
  2. all components per required task (i.e., rel attribute and class name)

@colbyfayock
Copy link
Owner Author

i don't think it makes sense to create a new PR for every component, but if you'd like to break up the work another way, such as one for pages and one for components, I'm open to that

@Azanul
Copy link

Azanul commented Oct 14, 2022

Not one PR for each component but one for half of them and another for other half

@colbyfayock
Copy link
Owner Author

let's do pages vs components as that sounds a little bit like a more logical difference

/src/pages
vs
/src/components

that sound good?

@Azanul
Copy link

Azanul commented Oct 14, 2022

By vs you mean one PR for pages and one for components right?

@Azanul
Copy link

Azanul commented Oct 14, 2022

Let me take up components then

@colbyfayock
Copy link
Owner Author

yup, sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants