Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support coins that are very far down the list #276

Open
lyricnz opened this issue Nov 14, 2021 · 5 comments · May be fixed by #312
Open

Support coins that are very far down the list #276

lyricnz opened this issue Nov 14, 2021 · 5 comments · May be fixed by #312
Labels
feature request

Comments

@lyricnz
Copy link
Collaborator

lyricnz commented Nov 14, 2021

We've had some support requests for coins that aren't in the top 1000 (or even the top 5000):

toKickUP: Hi, is it me or the BitDAO (symbol: BIT) is not included in cointop? I could not find it even if I keep cleaning the cache and reload the app.

felix78: Hi, how can I add Defina Finance FINA?
@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 14, 2021

I found FINA at around 5000 coins down the list

image

BIT has lots of duplicate symbols, and is even further down (on page 54, with 100-item pages)

image

@lyricnz lyricnz mentioned this issue Nov 14, 2021
Open
@miguelmota
Copy link
Member

not really trivial, but one thought on this is we could have the search function do a lookup via the API and merge the returned coin (if found) into the list of coins. The user can then add that coin as a favorite. Coingecko supports returning data for a specified list of coins so we can do an API fetch of just the favorited coins and merge those with the regular paginated lookup whenever cointop starts up or a refresh of the list of coins is made.

@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 14, 2021

Yup.

@blogdemoi
Copy link

Thank you lyricnz, I am felix78. So I have to wait for the next release of Cointop?

@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 20, 2021

Nobody has done this work - this is just a feature request

@lucasmr lucasmr linked a pull request Aug 7, 2022 that will close this issue
Open
@lyricnz lyricnz mentioned this issue Aug 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max_pages parameter to config file lucasmr/cointop_sandbox
3 participants
@lyricnz @miguelmota @blogdemoi