Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically avoid rate-limit rather than adding delays #267

Open
lyricnz opened this issue Nov 8, 2021 · 2 comments
Open

Dynamically avoid rate-limit rather than adding delays #267

lyricnz opened this issue Nov 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@lyricnz
Copy link
Collaborator

lyricnz commented Nov 8, 2021

Rather than adding arbitrary time-delays between operations, it may be better to count the current requests, and slow down (or pause) requests when we get close to a predefined limit (50/min for coingecko). This would improve apparent responsiveness of the interface. See #265 and #228
@lyricnz lyricnz added the enhancement New feature or request label Nov 8, 2021
@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 8, 2021

Or we could just wait for the error message, and (exponentially?) back off

@lyricnz
Copy link
Collaborator Author

lyricnz commented Nov 8, 2021

Need better visibility to HTTP/API errors on the screen too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lyricnz