Skip to content

[Go] Facilitator hooks registered but not integrated into Verify/Settle execution #1125

@madisoncarter1234

Description

@madisoncarter1234

Context

The Go SDK has a hook registration API (OnBeforeVerify, OnAfterVerify, OnVerifyFailure, OnBeforeSettle, OnAfterSettle, OnSettleFailure) and tests in facilitator_hooks_test.go, but there's a TODO on line 27:

// Note: Hooks are not fully integrated yet - this test validates hook registration works
// TODO: Integrate hooks into Verify execution

The tests assume hooks fire during Verify() and Settle(), but the TODO suggests they may not actually be wired up yet.

Question

Is the hook API stable and ready to be integrated into the Verify()/Settle() execution path, or is it still being designed? I'd be happy to put up a PR if the API is settled.

Files

  • go/facilitator_hooks_test.go:26-27
  • go/facilitator.go

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions