Skip to content

Commit e7dbe2e

Browse files
authored
Merge pull request #95 from gregwym/greg/shutdown-log
Log shutdown progress for activity and workflow pollers
2 parents 93c17bf + 1544f2d commit e7dbe2e

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 0.1.28
4+
- Log shutdown progress for activity and workflow pollers
5+
- Add WorkflowAlreadyCompletingError to the rbi file
6+
- Validate that a workflow isn't completed before recording commands
7+
- Ruby 3 compatibility
8+
39
## 0.1.21
410
- Add workflow id and activity id to workflow and activity logs
511

lib/cadence/activity/poller.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ def stop
3333

3434
def wait
3535
thread.join
36+
Cadence.logger.info('Draining activity worker job queue')
3637
thread_pool.shutdown
38+
Cadence.logger.info('Activity poller shutdown gracefully')
3739
end
3840

3941
private

lib/cadence/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Cadence
2-
VERSION = '0.1.21'.freeze
2+
VERSION = '0.1.28'.freeze
33
end

lib/cadence/workflow/poller.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,14 @@ def start
2929

3030
def stop
3131
@shutting_down = true
32-
Cadence.logger.info('Shutting down a workflow poller')
32+
Cadence.logger.info('Shutting down workflow poller')
3333
end
3434

3535
def wait
3636
@thread.join
37+
Cadence.logger.info('Draining workflow worker job queue')
3738
thread_pool.shutdown
39+
Cadence.logger.info('Workflow poller shutdown gracefully')
3840
end
3941

4042
private

0 commit comments

Comments
 (0)