Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate lowering the dependencies #19

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Jun 7, 2024

  • Requiring Symfony 6.4 LTS versions were possible
  • Introducing test matrix for PHP versions and also testing lowest deps
  • Removed composer.lock, this should be committed in the respective projects using Instructor, not in Instructor itself imho :)

Summary by CodeRabbit

  • New Features

    • Enhanced compatibility with Symfony components by allowing versions 6.4 and 7.0.
  • Chores

    • Updated CI workflow to test against PHP versions 8.2 and 8.3 with dynamic Composer flags for better dependency management.

Copy link

coderabbitai bot commented Jun 7, 2024

Walkthrough

The recent updates enhance the CI/CD pipeline and expand the compatibility of Symfony components. The workflow now dynamically tests various PHP versions (8.2 and 8.3) and Composer flags, while the composer.json adjustments allow flexibility with Symfony versions 6.4 and 7.0. These changes ensure broader compatibility and more robust testing.

Changes

File Change Summary
.github/workflows/php.yml Job names now include dynamic PHP versions and Composer flags. Added strategy for PHP versions 8.2, 8.3, and Composer flags. Updated dependency installation and test commands.
composer.json Adjusted version constraints for Symfony components to include compatibility with versions 6.4 and 7.0.

Poem

In the realm of code, where changes flow,
PHP versions dance, Composer flags glow,
Symfony components, now more free,
Embrace the future, in harmony.
With each update, our project grows,
A testament to the path we chose.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b49c9df and fae9849.

Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
Files selected for processing (2)
  • .github/workflows/php.yml (2 hunks)
  • composer.json (2 hunks)
Additional comments not posted (7)
.github/workflows/php.yml (4)

14-14: The dynamic naming of the CI job based on the matrix values enhances clarity in CI logs.


43-43: The test command remains standard and appropriate for running the test suite.


18-22: The expanded matrix strategy for PHP versions and Composer flags aligns with the PR objectives. Ensure that all combinations in the matrix are tested and work as expected.


40-40: The use of composer update with matrix Composer flags is crucial for testing the lowest dependencies. Verify that the flags are applied correctly during the CI process.

composer.json (3)

33-33: The addition of symfony/var-dumper with flexible version constraints supports the PR's goal of accommodating newer Symfony versions.


67-67: The addition of a script alias for running tests simplifies the test execution process.


46-59: The updated version constraints for Symfony components increase flexibility and future-proofing. Verify compatibility with all specified versions to ensure stability.

@ddebowczyk ddebowczyk merged commit 31b182d into cognesy:main Jun 7, 2024
0 of 4 checks passed
@ddebowczyk
Copy link
Contributor

Thank you, Yanick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants