Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Shell Window Error #177

Open
gabriel-vanca opened this issue Sep 14, 2024 · 2 comments · May be fixed by #178
Open

[BUG] Shell Window Error #177

gabriel-vanca opened this issue Sep 14, 2024 · 2 comments · May be fixed by #178

Comments

@gabriel-vanca
Copy link
Contributor

Using the "command" action, if the command files to execute via the first method in ActionMenus\Command\RepositoryActionCommandV1Mapper.cs , it tries the second method using the default Windows shell.
If Terminal is set as the default Terminal application, the shell will start via Terminal. Normally, the Terminal would close right away or not even show a window as the command would execute quickly, but if Terminal is misconfigured (such as using an inexistent fontstyle as it my case 🫤 ), it shows the following error:

image

Proposed solution: disable the window if the shell execute method runs.

This was referenced Sep 14, 2024
@coenm
Copy link
Owner

coenm commented Sep 14, 2024

I'm not sure if I follow and what the consequences are of your proposed fix.

Can you provide me with an example snippet (action menu) what you tried to execute:

- type: command@1
  ....

Thanks

@gabriel-vanca
Copy link
Contributor Author

gabriel-vanca commented Sep 15, 2024

Sure, I replied here: #178 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants