Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules throws crash the whole bot. #59

Open
neolectron opened this issue Sep 6, 2023 · 4 comments
Open

Modules throws crash the whole bot. #59

neolectron opened this issue Sep 6, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@neolectron
Copy link
Member

neolectron commented Sep 6, 2023

Today a module had crashed the whole bot.

I thought that the throw boundary was scoped to the client.on but maybe not.
We should check this.
image

I don't want to FORCE users to catch inside modules, although it's a good practice, a module should only crash itself. Bonus if it goes into disabled state after crashing.

@neolectron neolectron changed the title Modules crash the whole bot. Modules throws crash the whole bot. Sep 14, 2023
@ayoubqrt
Copy link
Contributor

ayoubqrt commented Sep 19, 2023

Are you sure about this ? I wanted to open an issue about that all the errors are silenced in the modules

@neolectron
Copy link
Member Author

What do you mean by silenced by the module ?

Do you have an example?

@neolectron neolectron added the bug Something isn't working label Sep 19, 2023
@ayoubqrt
Copy link
Contributor

For example, if I throw voluntarily in a event handler in a module, I see no errors in the console, so the debug is impossible
image

@potb
Copy link
Member

potb commented Oct 3, 2023

It happened today, again.
This time, it was because of a missing environment variable.

There is room for improvement regarding environment variables handling and error boundaries for modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants