Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlineToolbar always show convertTo, inconsist behavior with config value, and cannot be removed #2833

Open
zhaojjiang opened this issue Sep 29, 2024 · 3 comments

Comments

@zhaojjiang
Copy link

Describe a bug.

const editor = new EditorJS({
  holder: 'editor',
  tools: {
    paragraph: {
      // built-in inline tools: link, bold, italic
      // disable inline tools: false,
      inlineToolbar: ['bold', 'link'],
    },
  },
})

Expected behavior:

convertTo should also follow inlineToolbar config, which control it show or hide.

Screenshots:

image

As you see, it even show when no convertor available.

Device, Browser, OS:

Editor.js version:

Plugins you use with their versions:

@zhaojjiang zhaojjiang added the bug label Sep 29, 2024
@neSpecc neSpecc removed the bug label Nov 24, 2024
@idebenone
Copy link
Member

Hi @zhaojjiang,

We don't see any use-case for converting the 'convert to' tool optional as of now. Could you please elaborate if you have any use-cases for us?

@zhaojjiang
Copy link
Author

@idebenone just for customize,

and as mentioned above, "convert to" should not always show even there are no conventor

@neSpecc
Copy link
Member

neSpecc commented Nov 27, 2024

We should not show convertTo if there is no blocks to convert to. Seems like this logic was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants