Merge pull request activeadmin#1608 from railscard/default-csv-separator

Added config option to set default CSV builder separator

Author: James McKinney

app/views/active_admin/resource/index.csv.erb

@@ -7,7 +7,7 @@
               CSV
             end
 
-  csv_output = csv_lib.generate(:col_sep => active_admin_config.csv_builder.column_separator || ',') do |csv|
+  csv_output = csv_lib.generate(:col_sep => active_admin_config.csv_builder.column_separator || active_admin_application.csv_column_separator) do |csv|
     columns = active_admin_config.csv_builder.columns
     csv << columns.map(&:name)
     collection.each do |resource|

features/index/format_as_csv.feature

@@ -61,3 +61,21 @@ Feature: Format as CSV
       | Title        | Body |
       | Hello, World | (.*) |
 
+  Scenario: With default CSV separator option
+    Given a configuration of:
+    """
+      ActiveAdmin.application.csv_column_separator = ';'
+      ActiveAdmin.register Post do
+        csv do
+          column :title
+          column :body
+        end
+      end
+    """
+    And a post with the title "Hello, World" exists
+    When I am on the index page for posts
+    And I follow "CSV"
+    And I should download a CSV file with ";" separator for "posts" containing:
+      | Title | Body |
+      | Hello, World | (.*) |
+

lib/active_admin/application.rb

@@ -66,6 +66,9 @@ def self.inheritable_setting(name, default)
     # The namespace root.
     inheritable_setting :root_to, 'dashboard#index'
 
+    # Default CSV separator
+    inheritable_setting :csv_column_separator, ','
+
     # Active Admin makes educated guesses when displaying objects, this is
     # the list of methods it tries calling in order
     setting :display_name_methods, [ :display_name,

lib/generators/active_admin/install/templates/active_admin.rb.erb

@@ -140,4 +140,10 @@ ActiveAdmin.setup do |config|
   #
   # To load a javascript file:
   #   config.register_javascript 'my_javascript.js'
+
+
+  # == CSV options
+  #
+  # Set the CSV builder separator (default is ",")
+  # config.csv_column_separator = ','
 end