Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: drop PHP 8.0 support with CI 4.4 #7320

Closed
element-code opened this issue Mar 1, 2023 · 11 comments
Closed

Dev: drop PHP 8.0 support with CI 4.4 #7320

element-code opened this issue Mar 1, 2023 · 11 comments
Labels

Comments

@element-code
Copy link
Contributor

element-code commented Mar 1, 2023

PHP 8.0 will reach the end of life on 28 Nov 2022.
https://www.php.net/supported-versions.php

Relating to #6921 : guessing that this won't be CI 4.3 thing, so we are already at a breaking change then.
Whilst at it, drop PHP 8.0 as well, since it is already in its security-support-only phase (which itself ends in a few months 26 Nov 2023) and migration to at least PHP 8.1 should be in the process already.
This allows simplifying code using new features, at least for CI 4.4.
PHP 8.0 installation percentages are already dropping their share already, since people are upgrading to newer versions quicker than back in the day.

grafik
https://packagist.org/packages/codeigniter4/framework/php-stats

Using up energy supporting nearly EOL Versions in a "new PHP world" which is moving along way faster is a waste of energy in my opinion. It kinda feels like parts of the CI Community have not yet realized, that the "good old days" of having PHP 5.6 maintained for many years are over and moving along is the new normal.

@kenjis
Copy link
Member

kenjis commented Mar 2, 2023

The problem is the share of PHP 7.4.
I think dropping PHP 8.0 can be done only after dropping PHP 7.4.

@element-code
Copy link
Contributor Author

I think dropping PHP 8.0 can be done only after dropping PHP 7.4.

Yes I'm totally fine with that, for people who can't run CI 4.4 with PHP 7.4 anymore it would be not a problem to directly switch to PHP 8.1 / 8.2 instead of PHP 8.0.

The problem is the share of PHP 7.4.

My opinion is that sometimes forcing people to do the right thing is ok. E.g., forcing them to use a secure PHP version when they want to upgrade to CI 4.4
The point is, that as long as they run CI 4.3 they can use PHP 7.4, it just if they want to upgrade anyway.

@kenjis
Copy link
Member

kenjis commented Mar 2, 2023

I know your opinion.
This is a big change, so I think we need more discussion at our Forum.

@proff56
Copy link

proff56 commented Mar 9, 2023

big changes are the harbinger of growth... growth is good :)

@kenjis
Copy link
Member

kenjis commented Mar 9, 2023

I posted on the forum.
https://forum.codeigniter.com/showthread.php?tid=87036

@kenjis
Copy link
Member

kenjis commented Jun 18, 2023

PHPUnit 10 requires PHP 8.1 or PHP 8.2.
https://phpunit.de/getting-started/phpunit-10.html

@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

I would like to drop 8.0 in CI 4.5.

@kenjis
Copy link
Member

kenjis commented Oct 11, 2023

laminas-escaper 2.13 requires PHP 8.1 or later.
https://packagist.org/packages/laminas/laminas-escaper#2.13.0

@kenjis
Copy link
Member

kenjis commented Oct 13, 2023

PHP 7.4: 22.9%
PHP 8.0: 12.8%
Screenshot 2023-10-13 17 23 11

@kenjis kenjis mentioned this issue Oct 13, 2023
5 tasks
@kenjis
Copy link
Member

kenjis commented Oct 13, 2023

I sent PR #8042

@kenjis
Copy link
Member

kenjis commented Oct 21, 2023

PHP 8.0 support will be dropped in 4.5.

@kenjis kenjis closed this as completed Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants