Merge pull request #45 from codecrafters-io/fix-anti-cheat-1

Add new anti-cheat test cases for quantifier patterns and improve failure handling

Author: ryan-gang

internal/anti_cheat_quantifiers.go

@@ -16,6 +16,16 @@ func testQuantifiersAsAntiCheat(stageHarness *test_case_harness.TestCaseHarness)
 			Input:            "abc",
 			ExpectedExitCode: 1,
 		},
+		{
+			Pattern:          "a{2,}bc",
+			Input:            "aaaaabc",
+			ExpectedExitCode: 0,
+		},
+		{
+			Pattern:          "a{2,}bc",
+			Input:            "abc",
+			ExpectedExitCode: 1,
+		},
 	}
 
 	return testCaseCollection.Run(stageHarness)

internal/anti_cheat_test_case.go

@@ -17,6 +17,7 @@ type AntiCheatTestCaseCollection []AntiCheatTestCase
 func (c AntiCheatTestCaseCollection) Run(stageHarness *test_case_harness.TestCaseHarness) error {
 	logger := stageHarness.Logger
 
+	matchCount := 0
 	for _, testCase := range c {
 		executable := stageHarness.Executable.Clone()
 		executable.TimeoutInMilliseconds = 1000
@@ -26,11 +27,16 @@ func (c AntiCheatTestCaseCollection) Run(stageHarness *test_case_harness.TestCas
 			continue
 		}
 		if actualResult.ExitCode == testCase.ExpectedExitCode {
-			logger.Criticalf("anti-cheat (ac1) failed.")
-			logger.Criticalf("Please contact us at [email protected] if you think this is a mistake.")
-			return fmt.Errorf("anti-cheat (ac1) failed")
+			matchCount++
 		}
 	}
 
+	// Only if all anti-cheat test cases "fail", we fail the test
+	if matchCount == len(c) {
+		logger.Criticalf("anti-cheat (ac1) failed.")
+		logger.Criticalf("Please contact us at [email protected] if you think this is a mistake.")
+		return fmt.Errorf("anti-cheat (ac1) failed")
+	}
+
 	return nil
 }