Skip to content

Commit 754249a

Browse files
committed
Stop writing UploadLevelTotals
I believe these are completely unused. They were still being created/updated though.
1 parent 66ca059 commit 754249a

File tree

3 files changed

+0
-101
lines changed

3 files changed

+0
-101
lines changed

database/tests/factories/core.py

-15
Original file line numberDiff line numberDiff line change
@@ -233,21 +233,6 @@ class Meta:
233233
created_at = datetime.now()
234234

235235

236-
class UploadLevelTotalsFactory(Factory):
237-
class Meta:
238-
model = models.UploadLevelTotals
239-
240-
upload = factory.SubFactory(UploadFactory)
241-
branches = 0
242-
coverage = 0.00
243-
hits = 0
244-
lines = 0
245-
methods = 0
246-
misses = 0
247-
partials = 0
248-
files = 0
249-
250-
251236
class RepositoryFlagFactory(Factory):
252237
class Meta:
253238
model = models.RepositoryFlag

services/report/__init__.py

-25
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
ReportDetails,
3535
ReportLevelTotals,
3636
RepositoryFlag,
37-
UploadLevelTotals,
3837
)
3938
from helpers.environment import Environment, get_current_env
4039
from helpers.exceptions import (
@@ -1095,24 +1094,6 @@ def update_upload_with_processing_result(
10951094
upload_obj.state_id = UploadState.PROCESSED.db_id
10961095
upload_obj.state = "processed"
10971096
upload_obj.order_number = session.id
1098-
upload_totals = upload_obj.totals
1099-
if upload_totals is None:
1100-
upload_totals = UploadLevelTotals(
1101-
upload_id=upload_obj.id,
1102-
branches=0,
1103-
coverage=0,
1104-
hits=0,
1105-
lines=0,
1106-
methods=0,
1107-
misses=0,
1108-
partials=0,
1109-
files=0,
1110-
)
1111-
db_session.add(upload_totals)
1112-
if session.totals is not None:
1113-
upload_totals.update_from_totals(
1114-
session.totals, precision=precision, rounding=rounding
1115-
)
11161097
else:
11171098
error = processing_result.error
11181099
upload_obj.state = "error"
@@ -1252,12 +1233,6 @@ def save_full_report(
12521233
db_session.add(upload)
12531234
db_session.flush()
12541235
self._attach_flags_to_upload(upload, session.flags if session.flags else [])
1255-
if session.totals is not None:
1256-
upload_totals = UploadLevelTotals(upload_id=upload.id_)
1257-
db_session.add(upload_totals)
1258-
upload_totals.update_from_totals(
1259-
session.totals, precision=precision, rounding=rounding
1260-
)
12611236
return res
12621237

12631238
@sentry_sdk.trace

services/tests/test_report.py

-61
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
ReportLevelTotalsFactory,
1919
RepositoryFlagFactory,
2020
UploadFactory,
21-
UploadLevelTotalsFactory,
2221
)
2322
from helpers.exceptions import RepositoryWithoutValidBotError
2423
from services.archive import ArchiveService
@@ -477,18 +476,6 @@ def test_build_report_from_commit(self, dbsession, mock_storage):
477476

478477
upload = UploadFactory(report=report, order_number=0, upload_type="upload")
479478
dbsession.add(upload)
480-
upload_totals = UploadLevelTotalsFactory(
481-
upload=upload,
482-
files=3,
483-
lines=20,
484-
hits=17,
485-
misses=3,
486-
partials=0,
487-
coverage=85.0,
488-
branches=0,
489-
methods=0,
490-
)
491-
dbsession.add(upload_totals)
492479
dbsession.commit()
493480
dbsession.flush()
494481

@@ -606,73 +593,25 @@ def test_build_report_from_commit_with_flags(self, dbsession, mock_storage):
606593
report=report, flags=[flag1], order_number=0, upload_type="upload"
607594
)
608595
dbsession.add(upload1)
609-
upload_totals1 = UploadLevelTotalsFactory(
610-
upload=upload1,
611-
files=3,
612-
lines=20,
613-
hits=17,
614-
misses=3,
615-
partials=0,
616-
coverage=85.0,
617-
branches=0,
618-
methods=0,
619-
)
620-
dbsession.add(upload_totals1)
621596
dbsession.commit()
622597

623598
upload2 = UploadFactory(
624599
report=report, flags=[flag1], order_number=1, upload_type="carriedforward"
625600
)
626601
dbsession.add(upload2)
627-
upload_totals2 = UploadLevelTotalsFactory(
628-
upload=upload2,
629-
files=3,
630-
lines=20,
631-
hits=20,
632-
misses=0,
633-
partials=0,
634-
coverage=100.0,
635-
branches=0,
636-
methods=0,
637-
)
638-
dbsession.add(upload_totals2)
639602
dbsession.commit()
640603

641604
upload3 = UploadFactory(
642605
report=report, flags=[flag2], order_number=2, upload_type="carriedforward"
643606
)
644607
dbsession.add(upload3)
645-
upload_totals3 = UploadLevelTotalsFactory(
646-
upload=upload3,
647-
files=3,
648-
lines=20,
649-
hits=20,
650-
misses=0,
651-
partials=0,
652-
coverage=100.0,
653-
branches=0,
654-
methods=0,
655-
)
656-
dbsession.add(upload_totals3)
657608
dbsession.commit()
658609
dbsession.flush()
659610

660611
upload4 = UploadFactory(
661612
report=report, flags=[flag3], order_number=3, upload_type="upload"
662613
)
663614
dbsession.add(upload4)
664-
upload_totals4 = UploadLevelTotalsFactory(
665-
upload=upload4,
666-
files=3,
667-
lines=20,
668-
hits=20,
669-
misses=0,
670-
partials=0,
671-
coverage=100.0,
672-
branches=0,
673-
methods=0,
674-
)
675-
dbsession.add(upload_totals4)
676615
dbsession.commit()
677616
dbsession.flush()
678617

0 commit comments

Comments
 (0)