Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API support for collecting gzip info #1821

Closed
4 tasks done
Tracked by #1820 ...
nicholas-codecov opened this issue May 27, 2024 · 0 comments
Closed
4 tasks done
Tracked by #1820 ...

Add API support for collecting gzip info #1821

nicholas-codecov opened this issue May 27, 2024 · 0 comments
Assignees

Comments

@nicholas-codecov
Copy link

nicholas-codecov commented May 27, 2024

We're going to add support for collecting gzip information inside the bundler plugins, which will provide us with more accurate numbers for gzip size. So we need to add support either in the current schema or create a new schema version so that we can actually utilize this info once uploaded.

Note

We will only be collecting gzip information for Assets, and not modules

We'll also need to update the resolvers to grab this new value, or fallback to the previous way of calculating the gzip size

Bundle stats file schema: "version": "2" and anywhere there is "size" there will be a "gzipSize"

During ingestion, if version 2 will save gzipSize with the specified value.
Note need to add a gzipSize column to asset and module tables.

During the SQLite migration, when adding gzipSize column default to the GZIP = 0.001 compression ratio we currently display.

In API just retrieve the gzipSize column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants