Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ci and docs #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: added ci and docs #351

wants to merge 1 commit into from

Conversation

ezhil56x
Copy link

@ezhil56x ezhil56x commented Jun 3, 2024

Resolves #350

  • Added ci for lint check. Now ci will fail if the code is not linted
  • Formatted the whole repo
  • Updated README.md and added CONTRIBUTING.md which would be useful for new contributors

@siinghd
Copy link
Collaborator

siinghd commented Jun 17, 2024

@ezhil56x merge conflicts

@ezhil56x
Copy link
Author

@siinghd Ready to go!

steps:
- name: Checkout the Repository
uses: actions/checkout@v4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we setup nodejs here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its not required as ubuntu-latest comes with yarn and node

Copy link
Collaborator

@siinghd siinghd Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this?

@ezhil56x
Copy link
Author

@siinghd Resolved conflicts

@siinghd
Copy link
Collaborator

siinghd commented Jun 30, 2024

@ezhil56x can u fix ur linter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: continuous integration is not setup for lint check
2 participants