Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD-01 MitigationConfirmed #22

Open
c4-bot-3 opened this issue Sep 15, 2024 · 2 comments
Open

ADD-01 MitigationConfirmed #22

c4-bot-3 opened this issue Sep 15, 2024 · 2 comments
Labels
confirmed for report This issue is confirmed for report edited-by-warden mitigation-confirmed MR-ADD-01 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-3
Copy link
Contributor

c4-bot-3 commented Sep 15, 2024

Lines of code

Vulnerability details

Lines of code

Vulnerability details

C4 Issue:

H-01: code-423n4/2024-07-karak-findings#102

Comments

This mitigation is a part of a mitigation of H-01. The issue was discovered after implemented recommended audit fixes. Before implementing this mitigation, burnt ETH that was slashed was not subtracted from the node.withdrawableCreditedNodeETH, even though it was swept and not available for withdrawal anymore.

Mitigation

FIX
Now when _burnSlashed() is called and slashed ETH is swept, it is subtracted from the node.withdrawableCreditedNodeETH, so it's no longer available for withdrawal. This change keeps the accounting correct and resolves the issue.

Conclusion

LGTM

c4-bot-1 added a commit that referenced this issue Sep 15, 2024
@c4-bot-2 c4-bot-2 changed the title ADD-02 MitigationConfirmed ADD-01 MitigationConfirmed Sep 15, 2024
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Sep 18, 2024
@c4-judge
Copy link

MiloTruck marked the issue as satisfactory

@c4-judge
Copy link

MiloTruck marked the issue as confirmed for report

@c4-judge c4-judge added the confirmed for report This issue is confirmed for report label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed for report This issue is confirmed for report edited-by-warden mitigation-confirmed MR-ADD-01 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

4 participants