Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS-606] Invalid version release-branch #89

Open
zyexal opened this issue Oct 5, 2023 · 2 comments
Open

[TS-606] Invalid version release-branch #89

zyexal opened this issue Oct 5, 2023 · 2 comments
Labels
jira-issue Issue tracked on JIRA

Comments

@zyexal
Copy link

zyexal commented Oct 5, 2023

I have noticed that the outputs.version on the release-branch can be invalid.

Observed scenario:

  • The project has a single existing tag 0.0.1 and a release-branch named main
  • The codacy/[email protected] output on main:
    • received:
      Previous Version: 0.0.0
      New Version: 0.0.1
    • expected:
      Previous Version: 0.0.1
      New Version: 0.0.2

After adding another tag 0.0.2 I got the output:

  • as expected
    Previous Version: 0.0.2
    New Version: 0.0.3

This cause me to assure, that at least two tags exists before being able to use the codacy/[email protected]

@github-actions github-actions bot changed the title Invalid version release-branch [TS-606] Invalid version release-branch Oct 5, 2023
@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Internal ticket created : TS-606

@skraussppro
Copy link

Folks I could find out, that the issue is related to the usage of s4u/[email protected]

Causes the issue:

      - name: Prepare Maven
        uses: s4u/[email protected]
        with:
          java-version: ${{env.JAVA_VERSION}}

      - name: Check Version
        id: version
        uses: codacy/[email protected]
        with:
          release-branch: main

Does not cause the issue

      - name: Check Version
        id: version
        uses: codacy/[email protected]
        with:
          release-branch: main
          
      - name: Prepare Maven
        uses: s4u/[email protected]
        with:
          java-version: ${{env.JAVA_VERSION}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

2 participants