Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CY-6611] "breaking:" word always bumps the major version, not just at the start of the commit message #64

Open
nfcodacy opened this issue Nov 11, 2022 · 1 comment
Labels
jira-issue Issue tracked on JIRA

Comments

@nfcodacy
Copy link

A commit message that has "breaking:" in any part of it will trigger a major version bump, even if it is inside a comment (# :breaking:).

Can this be reviewed to only match "breaking:" and "feature:" at the start of the commit message?

I think that only the following commit messages should trigger a bump:
"breaking: (...)"
":breaking: (...)"
" breaking: (...)" (leading whitespaces but not newline)
" :breaking: (...)" (leading whitespaces but not newline)
and then the same thing for "feature:".

@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Nov 11, 2022
@github-actions
Copy link

Internal ticket created : CY-6611

@github-actions github-actions bot changed the title "breaking:" word always bumps the major version, not just at the start of the commit message [CY-6611] "breaking:" word always bumps the major version, not just at the start of the commit message Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

1 participant