Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision of React Props and Angular Component Class Members #108

Open
daniel-nagy opened this issue Aug 7, 2019 · 1 comment
Open

Collision of React Props and Angular Component Class Members #108

daniel-nagy opened this issue Aug 7, 2019 · 1 comment

Comments

@daniel-nagy
Copy link

If I have a prop with the same name as a class member it will overwrite the class member. For example, if I try to pass a render prop to my React component it will overwrite the render method of the Angular component controller.

Using scope instead of bindings may fix the issue as long as the component lifecycle methods are still invoked.

@daniel-nagy
Copy link
Author

daniel-nagy commented Aug 7, 2019

The $ngChanges lifecycle method doesn't work when using scope 😕.

It's not really necessary to use the conveniences of the NgComponent class with this module. This module could do away with it and properly hide its implementation so it doesn't collide with any Angular bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant