-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-review/: Redesign the webpage #254
base: master
Are you sure you want to change the base?
Conversation
05498e6
to
8719d4e
Compare
8719d4e
to
b8b1c32
Compare
b8b1c32
to
c5b944e
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: b07e0200-ac50-11e9-a8f1-bbdc807b8a3b |
c5b944e
to
90f6fee
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
pytest
TravisBuddy Request Identifier: 012922e0-b366-11e9-a522-656c855f12dd |
90f6fee
to
05e7d4e
Compare
The updation in model adds new data fields which will be useful, in further work. Also, it will reduce the API calls, which are being made to fetch these information. Instead of making new API Calls, we can get them from webservices and use them directly.
The openhub module got disabled due to some reasons in community project last year. And, currently the module is raising the CI errors which need to be avoided. They can be worked on once we're ready to enable the openhub module once again in this project in future.
As in future, the data will be fetched from coala-webservices intead of @sks444 repository (webservices.coala.io). So, to remove that dependency the tests have been modified accordingly.
Running command ".ci/build.sh" locally on pc used to failed the build, if there is more than one git remote's. Fixes coala#235
0b0ab8f
to
47ac600
Compare
The enhancement includes addition of materialize css, JQuery, responsiveness, and easy-navigation of website features. The easy-navigatibility is achieved by adding a navbar with display of meta -review and gamification leaderboard on homepage. Apart from this, the activity graph url is omitted from website by displaying the graph itslef on the homepage on large devices. Closes coala#255
The newly created webpage combines the previous two webpages- info.txt and log/index.html. This web-page combines the results of both the pages and shows them in a better UI/UX with additional features of filtering and searching within the existing logs. The logs are fetched from a JSON file which is created from the logs stored in the log file _site/community.log Closes coala#256
The redesigned web-page displays the data in a better UI/UX form with some additional information to make it more interactive and attractive. Closes coala#257
47ac600
to
a188e9d
Compare
a188e9d
to
c2f5c96
Compare
Do not close GitLab issues from here as mentioned earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the search functionality, can it be case insensitive?
templates/meta_review.html
Outdated
</div> | ||
<div class="metareviewer-details"> | ||
<div class="contributor-details-part-1 column-flex"> | ||
<a class="bold-text large-font" href="//github.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is not working for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check if it is feasible to make it case insensitive!
And will also check why the link the isn't working as it is an anchor tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made search case insensitive and the link too now is working 👍
The redesigned web-page provides a nice UI/UX design to the web-page with "search" feature. Closes coala#259
c2f5c96
to
cafc7e6
Compare
The redesigned web-page provides a nice
UI/UX design to the web-page with "search"
feature.
Closes #259