Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People import fails for countries with commas #888

Open
cjyabraham opened this issue Sep 23, 2024 · 1 comment
Open

People import fails for countries with commas #888

cjyabraham opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
idea idea for the future

Comments

@cjyabraham
Copy link
Collaborator

cjyabraham commented Sep 23, 2024

We split the "location" field in the people.json file on the commas to find the country as the last element of this array. The problem is that some of the countries in our database have commas in them, such as "Moldova, Republic of", so there's no way for anyone to find a match with this country. We have a person who has put "location": "Chisinau, Moldova" and another who has "location": "Chisinau, Republic of Moldova" so we need to find a way to work with these entries. There are other countries too that will run into this problem.

@cjyabraham cjyabraham self-assigned this Sep 23, 2024
@github-project-automation github-project-automation bot moved this to Triage in CNCF.io Sep 23, 2024
@cjyabraham cjyabraham moved this from Triage to Soon in CNCF.io Sep 23, 2024
@cjyabraham
Copy link
Collaborator Author

For now, I've edited "Moldova, Republic of" to be just "Moldova" in both the CNCF site and the people json file so now they are matching correctly. I'll leave this open but demote priority in case we need a more general solution to accommodate commas later.

@cjyabraham cjyabraham moved this from Soon to Later in CNCF.io Sep 30, 2024
@cjyabraham cjyabraham added the idea idea for the future label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea idea for the future
Projects
Status: Later
Development

No branches or pull requests

1 participant